[U-Boot] [U-Boot, 1/1] fs: fat: validate sector and cluster size

Tom Rini trini at konsulko.com
Tue Nov 20 20:33:18 UTC 2018


On Tue, Nov 20, 2018 at 09:29:34PM +0100, Heinrich Schuchardt wrote:

> On 11/20/18 3:56 PM, Tom Rini wrote:
> > On Wed, Oct 31, 2018 at 09:46:36PM +0100, Heinrich Schuchardt wrote:
> > 
> >> In the rest of the FAT driver we want to be able to rely on the fact that
> >> the cluster size is a power of two. So let's check that both the sector
> >> size and the number of sectors per cluster are valid.
> >>
> >> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> > 
> > This breaks a number of tests under test/py/tests/test_fs/test_basic.py
> > as seen under 'make tests'.
> > 
> 
> Hello Tom,
> 
> I am not able to reproduce your observation based on commit
> d73d81fd85e4a030ade42c4b2d13466d45090aa3 (master HEAD). See test output
> below.
[snip]
> test/py/tests/test_fs/test_basic.py
> sssssssssssssssssssssssssssssssssssssss

OK, my fault for being imprecise.  These tests here are the ones that
fail and you have them being skipped.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181120/236291ee/attachment.sig>


More information about the U-Boot mailing list