[U-Boot] [U-Boot, 1/1] fs: fat: validate sector and cluster size

Heinrich Schuchardt xypron.glpk at gmx.de
Tue Nov 20 22:08:54 UTC 2018


On 11/20/18 9:33 PM, Tom Rini wrote:
> On Tue, Nov 20, 2018 at 09:29:34PM +0100, Heinrich Schuchardt wrote:
> 
>> On 11/20/18 3:56 PM, Tom Rini wrote:
>>> On Wed, Oct 31, 2018 at 09:46:36PM +0100, Heinrich Schuchardt wrote:
>>>
>>>> In the rest of the FAT driver we want to be able to rely on the fact that
>>>> the cluster size is a power of two. So let's check that both the sector
>>>> size and the number of sectors per cluster are valid.
>>>>
>>>> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>>>
>>> This breaks a number of tests under test/py/tests/test_fs/test_basic.py
>>> as seen under 'make tests'.
>>>
>>
>> Hello Tom,
>>
>> I am not able to reproduce your observation based on commit
>> d73d81fd85e4a030ade42c4b2d13466d45090aa3 (master HEAD). See test output
>> below.
> [snip]
>> test/py/tests/test_fs/test_basic.py
>> sssssssssssssssssssssssssssssssssssssss
> 
> OK, my fault for being imprecise.  These tests here are the ones that
> fail and you have them being skipped.
>  r


make tests is building sandbox. Why are the tests skipped? I did not set
them to skipped explicitly.

The tests make reference to a file system. Where is it built?

Regards Heinrich


More information about the U-Boot mailing list