[U-Boot] [PATCH 5/6] test: Add PCI device entry without compat string and with DT node

Marek Vasut marek.vasut at gmail.com
Mon Oct 1 11:44:18 UTC 2018


On 09/25/2018 05:26 PM, Bin Meng wrote:
> Hi Marek,
> 
> On Sat, Sep 22, 2018 at 7:02 AM Marek Vasut <marek.vasut at gmail.com> wrote:
>>
>> Add PCI entry without compatible string and with a DT node only with
>> reg = <...> property into the DT. This is needed for the tests to
>> verify whether such a setup creates an U-Boot PCI device with the
>> DT node associated with it in udevice.node.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas at gmail.com>
>> Cc: Simon Glass <sjg at chromium.org>
>> Cc: Tom Rini <trini at konsulko.com>
>> ---
>>  arch/sandbox/dts/test.dts | 9 +++++++--
>>  1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts
>> index b8524e3b7d..c13a270c2e 100644
>> --- a/arch/sandbox/dts/test.dts
>> +++ b/arch/sandbox/dts/test.dts
>> @@ -354,9 +354,14 @@
>>                 #address-cells = <3>;
>>                 #size-cells = <2>;
>>                 ranges = <0x02000000 0 0x30000000 0x30000000 0 0x2000
>> -                               0x01000000 0 0x40000000 0x40000000 0 0x2000>;
>> +                         0x01000000 0 0x40000000 0x40000000 0 0x2000
>> +                         0x00008000 0 0x00000000 0x00008000 0 0x2000>;
> 
> Adding this line makes no sense. You can't translate a PCI bus
> configuration space address (0x8000) to something in its parent bus's
> (MMIO) address space. See my related comments in patch 1 and 3.
> 

So what should be in that line ?

-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list