[U-Boot] [PATCH 15/18] armv8: ls1088a: add i2c entry

[York Sun]

On 08/22/2018 06:15 PM, ying.zhang22455 at nxp.com wrote:
> From: Zhang Ying-22455 <ying.zhang22455 at nxp.com>
> 
> Signed-off-by: Zhang Ying-22455 <ying.zhang22455 at nxp.com>
> ---
>  arch/arm/dts/fsl-ls1088a-qds.dts | 57 ++++++++++++++++++++++++++++++++++++++++
>  arch/arm/dts/fsl-ls1088a-rdb.dts | 40 ++++++++++++++++++++++++++++
>  arch/arm/dts/fsl-ls1088a.dtsi    | 55 ++++++++++++++++++++++++++++++++++++++
>  3 files changed, 152 insertions(+)
> 
> diff --git a/arch/arm/dts/fsl-ls1088a-qds.dts b/arch/arm/dts/fsl-ls1088a-qds.dts
> index 36116f7..3913621 100644
> --- a/arch/arm/dts/fsl-ls1088a-qds.dts
> +++ b/arch/arm/dts/fsl-ls1088a-qds.dts
> @@ -18,6 +18,63 @@
>  	};
>  };
>  
> +&i2c0 {
> +	status = "okay";
> +
> +	i2c-switch at 77 {
> +		compatible = "nxp,pca9547";
> +		reg = <0x77>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		i2c at 2 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <0x2>;
> +
> +			ina220 at 40 {
> +				compatible = "ti,ina220";
> +				reg = <0x40>;
> +				shunt-resistor = <1000>;
> +			};
> +
> +			ina220 at 41 {
> +				compatible = "ti,ina220";
> +				reg = <0x41>;
> +				shunt-resistor = <1000>;
> +			};
> +		};
> +
> +		i2c at 3 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <0x3>;
> +
> +			temp-sensor at 4c {
> +				compatible = "adi,adt7461a";
> +				reg = <0x4c>;
> +			};
> +
> +			rtc at 51 {
> +				compatible = "nxp,pcf2129";
> +				reg = <0x51>;
> +				/* IRQ10_B */
> +				interrupts = <0 150 4>;
> +			};
> +
> +			eeprom at 56 {
> +				compatible = "atmel,24c512";
> +				reg = <0x56>;
> +			};
> +
> +			eeprom at 57 {
> +				compatible = "atmel,24c512";
> +				reg = <0x57>;
> +			};
> +		};
> +	};
> +};
> +
>  &ifc {
>  	#address-cells = <2>;
>  	#size-cells = <1>;
> diff --git a/arch/arm/dts/fsl-ls1088a-rdb.dts b/arch/arm/dts/fsl-ls1088a-rdb.dts
> index 0be3f8d..6eb0560 100644
> --- a/arch/arm/dts/fsl-ls1088a-rdb.dts
> +++ b/arch/arm/dts/fsl-ls1088a-rdb.dts
> @@ -17,6 +17,46 @@
>  	};
>  };
>  
> +&i2c0 {
> +	status = "okay";
> +
> +	i2c-switch at 77 {
> +		compatible = "nxp,pca9547";
> +		reg = <0x77>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		i2c at 2 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <0x2>;
> +
> +			ina220 at 40 {
> +				compatible = "ti,ina220";
> +				reg = <0x40>;
> +				shunt-resistor = <1000>;
> +			};
> +		};
> +
> +		i2c at 3 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <0x3>;
> +
> +			temp-sensor at 4c {
> +				compatible = "adi,adt7461a";
> +				reg = <0x4c>;
> +			};
> +
> +			rtc at 51 {
> +				compatible = "nxp,pcf2129";
> +				reg = <0x51>;
> +				/* IRQ10_B */
> +				interrupts = <0 150 4>;
> +			};
> +		};
> +	};
> +};
>  &qspi {
>  	bus-num = <0>;
>  	status = "okay";
> diff --git a/arch/arm/dts/fsl-ls1088a.dtsi b/arch/arm/dts/fsl-ls1088a.dtsi
> index acc63be..7178b68 100644
> --- a/arch/arm/dts/fsl-ls1088a.dtsi
> +++ b/arch/arm/dts/fsl-ls1088a.dtsi
> @@ -26,6 +26,13 @@
>  		interrupts = <1 9 0x4>;
>  	};
>  
> +	sysclk: sysclk {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <100000000>;
> +		clock-output-names = "sysclk";
> +        };

You have space instead of tab here.

> +
>  	timer {
>  		compatible = "arm,armv8-timer";
>  		interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */
> @@ -34,6 +41,54 @@
>  			     <1 10 0x8>; /* Hypervisor PPI, active-low */
>  	};
>  
> +

You have extra blank line here.

Did you run checkpatch?

York