[U-Boot] [PATCH] dm: core: Widen the dump tree to show more of the driver's name.

[Liviu Dudau]

On Tue, Oct 02, 2018 at 04:22:25AM -0700, Simon Glass wrote:
> Hi Liviu,
> 
> On 2 October 2018 at 03:46, Liviu Dudau <Liviu.Dudau at foss.arm.com> wrote:
> > On Fri, Sep 28, 2018 at 04:14:12PM -0600, Simon Glass wrote:
> >> Hi,
> >
> > Hi Simon,
> >
> >>
> >> On 17 September 2018 at 20:06, Simon Glass <sjg at chromium.org> wrote:
> >> > On 17 September 2018 at 10:57, Liviu Dudau <Liviu.Dudau at foss.arm.com> wrote:
> >> >> With drivers that have prefix names that are quite long (like
> >> >> 'versatile_') it is useful to have a wider column for the driver's
> >> >> name when dumping the device driver tree.
> >> >>
> >> >> Signed-off-by: Liviu Dudau <liviu.dudau at foss.arm.com>
> >> >> ---
> >> >>  drivers/core/dump.c | 8 ++++----
> >> >>  1 file changed, 4 insertions(+), 4 deletions(-)
> >> >
> >> > Reviewed-by: Simon Glass <sjg at chromium.org>
> >>
> >> Unfortunately this seems to break some tests (make tests). Please can
> >> you take a look?
> >
> > I've had a go at trying to run 'make tests' on my machine but things
> > fail miserably for me. Attached is the output of the command. U-Boot is
> > v2018.11-rc1 plus my remaining patches that have not yet been merged.
> >
> > It looks to me like the 'sandbox' board (or defconfig) needs some
> > updating? Please advise!
> 
> I cannot explain your build log - it looks completely wrong.
> 
> Can you try:
> 
> make O=sandbox sandbox_defconfig
> make O=sandbox
> 
> ?
> 
> Maybe try 'make mrproper' first?

I've done that before.

> 
> But still, the errors seems to make no sense. E.g.
> CONFIG_SANDBOX_SPI_MAX_BUS is defined in a config file.

I think I have fixed the issue. I believe it was due to some stray
include/config.mk file that was a leftover from the times I switched to
an old Exynos tree trying to update an SMDK4422 board.

I can now see the relevant errors and I will come up with a patch.

Many thanks,
Liviu

> 
> Also what gcc version are you using on your computer?
> 
> Regards,
> Simon

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯