[U-Boot] [PATCH 04/20] arm: dts: MediaTek: add MT7629 reference board support

[Matthias Brugger]

I'm very happy to see Mediatek working on mainline u-boot support!

On 02/10/2018 08:13, Ryder Lee wrote:
> This patch adds mt7629.dtsi and reference board support.
I think reference board support is already added in 2/20.
AFAICS you just device tree and the includes it needs.

> 
> Signed-off-by: Ryder Lee <ryder.lee at mediatek.com>
> ---
>  arch/arm/dts/Makefile                    |   3 +
>  arch/arm/dts/mt7629-rfb.dts              |  71 ++++++++++
>  arch/arm/dts/mt7629.dtsi                 | 232 +++++++++++++++++++++++++++++++
>  include/configs/mt7629.h                 |   2 +
>  include/dt-bindings/clock/mt7629-clk.h   | 217 +++++++++++++++++++++++++++++
>  include/dt-bindings/power/mt7629-power.h |  13 ++
>  6 files changed, 538 insertions(+)
>  create mode 100644 arch/arm/dts/mt7629-rfb.dts
>  create mode 100644 arch/arm/dts/mt7629.dtsi
>  create mode 100644 include/dt-bindings/clock/mt7629-clk.h
>  create mode 100644 include/dt-bindings/power/mt7629-power.h
> 
[...]
> +
> +	watchdog: watchdog at 10212000 {
> +		compatible = "mediatek,wdt";

Will this be passed to the kernel later?
If so, you should add a upstream-like compatible (at least).
BTW none of the mt7629 compatible is upstream in the kernel. Not sure if that's
an issue for u-boot, TBH.

> +		reg = <0x10212000 0x600>;
> +		interrupts = <GIC_SPI 128 IRQ_TYPE_EDGE_FALLING>;
> +		#reset-cells = <1>;
> +		status = "disabled";
> +	};
> +
> +	wdt-reboot {
> +		compatible = "wdt-reboot";
> +		wdt = <&watchdog>;
> +	};
> +

Regards,
Matthias