[U-Boot] [PATCH V2] spl: Weed out CONFIG_SYS_TEXT_BASE usage

[Michal Simek]

On 4.10.2018 09:02, Marek Vasut wrote:
> On 10/04/2018 08:00 AM, Michal Simek wrote:
>> On 3.10.2018 21:41, Marek Vasut wrote:
>>> On 10/03/2018 03:39 PM, Michal Simek wrote:
>>>> Hi Marek,
>>>
>>> Hi,
>>>
>>> [...]
>>>
>>>>> diff --git a/common/spl/spl_ram.c b/common/spl/spl_ram.c
>>>>> index e594beaeaa..619b39a537 100644
>>>>> --- a/common/spl/spl_ram.c
>>>>> +++ b/common/spl/spl_ram.c
>>>>> @@ -63,8 +63,9 @@ static int spl_ram_load_image(struct spl_image_info
>>>>> *spl_image,
>>>>>                          * No binman support or no information. For now,
>>>>> fix it
>>>>>                          * to the address pointed to by U-Boot.
>>>>>                          */
>>>>> -                       u_boot_pos = CONFIG_SYS_TEXT_BASE -
>>>>> -                                       sizeof(struct image_header);
>>>>> +                       header = spl_get_load_buffer(-sizeof(*header),
>>>>> +                                                    sizeof(*header));
>>>>> +
>>>>>
>>>>
>>>> I am curious how you have tested this change.
>>>> Because I see on my zc706 that this breaks my SPL boot flow.
>>>
>>> Definitely not on every single board we support ...
>>
>>
>> non has asked for testing on every single board but you should test or
>> at least ask for testing modes which you are not able to test yourself.
> 
> You had the chance to review or test the patch while it was on the ML,
> it was there for a long time (months?), that's what the review process
> is for. Review process didn't catch it, so send a fix ...


2 patches sent.

M