[U-Boot] [PATCH v2 01/23] log: Correct definition of log_msg_ret()

[Bin Meng]

Hi Simon,

On Tue, Oct 2, 2018 at 8:25 PM Simon Glass <sjg at chromium.org> wrote:
>
> This macro should have two parameters, not one. Fix it so that it
> correctly resolves to _ret when logging is disabled.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
> Changes in v2: None
>
>  include/log.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/log.h b/include/log.h
> index 653fb8d853e..75ff1e1160c 100644
> --- a/include/log.h
> +++ b/include/log.h
> @@ -175,7 +175,7 @@ void __assert_fail(const char *assertion, const char *file, unsigned int line,
>         })
>  #else
>  #define log_ret(_ret) (_ret)
> -#define log_msg_ret(_ret) (_ret)
> +#define log_msg_ret(_msg, _ret) (_ret)

This creates a warning still if logging is disabled.

include/log.h:178:33: warning: statement with no effect [-Wunused-value]
 #define log_msg_ret(_msg, _ret) (_ret)

Regards,
Bin