[U-Boot] [PATCH 16/53] drivers: qe: add TFABOOT support

[Rajesh Bhagat]

> -----Original Message-----
> From: York Sun
> Sent: Wednesday, October 3, 2018 9:50 PM
> To: Rajesh Bhagat <rajesh.bhagat at nxp.com>; u-boot at lists.denx.de
> Cc: Prabhakar Kushwaha <prabhakar.kushwaha at nxp.com>; Pankit Garg
> <pankit.garg at nxp.com>
> Subject: Re: [PATCH 16/53] drivers: qe: add TFABOOT support
> 
> On 10/03/2018 04:39 AM, Rajesh Bhagat wrote:
> > Adds TFABOOT support and allows to pick QE firmware on basis of boot
> > source.
> >
> > Signed-off-by: Pankit Garg <pankit.garg at nxp.com>
> > Signed-off-by: Rajesh Bhagat <rajesh.bhagat at nxp.com>
> > ---
> >  drivers/qe/qe.c | 81
> > +++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 81 insertions(+)
> >
> > diff --git a/drivers/qe/qe.c b/drivers/qe/qe.c index
> > 7654df8008..d7e3a1b923 100644
> > --- a/drivers/qe/qe.c
> > +++ b/drivers/qe/qe.c
> > @@ -17,9 +17,17 @@
> >  #include <asm/arch/immap_ls102xa.h>
> >  #endif
> >
> > +#ifdef CONFIG_TFABOOT
> > +#include <mmc.h>
> > +/* required to include IFC and QSPI base address */ #include
> > +<asm/armv8/mmu.h> #include <asm/arch/cpu.h> #include
> <environment.h>
> > +#else
> 
> You have many of this ifdef. Please fix all if you don't have to use ifdef.
> 

Will take care in v2. 

> York