[U-Boot] [PATCH] common: Add arch_misc_init() prototype to include/init.h
Patrick DELAUNAY
patrick.delaunay at st.com
Thu Oct 4 12:16:44 UTC 2018
Hi Stefan
> From: Stefan Roese <sr at denx.de>
> Sent: jeudi 4 octobre 2018 13:39
>
> When implementing arch_misc_init() for the MT7620 platform I noticed that this
> function prototype is missing. Lets add this prototype to the common place
> (init.h) so that we use this function on all architectures.
>
> Signed-off-by: Stefan Roese <sr at denx.de>
> Cc: Daniel Schwierzeck <daniel.schwierzeck at gmail.com>
> Cc: Patrick Delaunay <patrick.delaunay at st.com>
> Cc: Tom Rini <trini at konsulko.com>
> ---
> include/init.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/init.h b/include/init.h index afc953d51e..3593567d52 100644
> --- a/include/init.h
> +++ b/include/init.h
> @@ -165,6 +165,7 @@ void arch_setup_gd(gd_t *gd_ptr);
> /* common/board_r.c */
> void board_init_r(gd_t *id, ulong dest_addr) __attribute__ ((noreturn));
>
> +int arch_misc_init(void);
> int cpu_init_r(void);
> int last_stage_init(void);
> int mac_read_from_eeprom(void);
> --
> 2.19.0
I found prototype of the function for arm and x86 in
./arch/arm/include/asm/u-boot-arm.h:35:int arch_misc_init(void);
./arch/x86/include/asm/u-boot-x86.h:73:int arch_misc_init(void);
I think , theyr should be removed in this include if a generic prototype is defined in init.h
But it is the fact for other prototypes for "cpu.c", at least for
- arch_cpu_init
- arch_early_init_r
include path is :
./include/common.h:51:#include <asm/u-boot.h>
./arch/arm/include/asm/u-boot.h:24:#include <asm/u-boot-arm.h>
Regards
Patrick
More information about the U-Boot
mailing list