[U-Boot] [PATCH 1/4] net: dm: fec: Fix time unit error in phy-reset-duration

Michael Nazzareno Trimarchi michael at amarulasolutions.com
Fri Oct 5 05:42:58 UTC 2018


Hi

On Thu, Oct 4, 2018 at 7:59 PM Martin Fuzzey
<martin.fuzzey at flowbird.group> wrote:
>
> The DT binding says that phy-reset-duration is in ms, but the driver
> currently uses udelay().
>
> Switch to mdelay() to fix this.
>
> Signed-off-by: Martin Fuzzey <martin.fuzzey at flowbird.group>
> ---
>  drivers/net/fec_mxc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
> index dac07b6..a1295fc 100644
> --- a/drivers/net/fec_mxc.c
> +++ b/drivers/net/fec_mxc.c
> @@ -1254,7 +1254,7 @@ static void fec_gpio_reset(struct fec_priv *priv)
>         debug("fec_gpio_reset: fec_gpio_reset(dev)\n");
>         if (dm_gpio_is_valid(&priv->phy_reset_gpio)) {
>                 dm_gpio_set_value(&priv->phy_reset_gpio, 1);
> -               udelay(priv->reset_delay);
> +               mdelay(priv->reset_delay);
>                 dm_gpio_set_value(&priv->phy_reset_gpio, 0);
>         }

Reviewed-by: Michael Trimarchi <michael at amarulasolutions.com>
>  }
> --
> 1.9.1
>


-- 
| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |


More information about the U-Boot mailing list