[U-Boot] [PATCH v1 12/19] configs: am335x_pdu001: Explicitly enable CONFIG_I2C_COMPAT

[Jean-Jacques Hiblot]

Hi Felix,

On 05/10/2018 14:25, Felix Brack wrote:
> Hello Jean-Jacques,
>
> On 04.10.2018 15:47, Jean-Jacques Hiblot wrote:
>> CONFIG_I2C_COMPAT is currently enabled in ti_armv7_common.h
>> Let us use the Kconfig option instead so that any change to
>> CONFIG_I2C_COMPAT in ti_armv7_common.h doesn't break this platform.
>>
> As I can't find CONFIG_I2C_COMPAT anywhere I guess it is a typo and you
> had meant CONFIG_DM_I2C_COMPAT.

>
>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot at ti.com>
>> ---
>>
>>   configs/am335x_pdu001_defconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/configs/am335x_pdu001_defconfig b/configs/am335x_pdu001_defconfig
>> index a666318..6e66e68 100644
>> --- a/configs/am335x_pdu001_defconfig
>> +++ b/configs/am335x_pdu001_defconfig
>> @@ -38,6 +38,7 @@ CONFIG_SPL_DM=y
>>   CONFIG_SPL_DM_SEQ_ALIAS=y
>>   CONFIG_DM_GPIO=y
>>   CONFIG_DM_I2C=y
>> +CONFIG_DM_I2C_COMPAT=y
> This is neither required nor wanted. CONFIG_DM_I2C_COMPAT is _undefined_
> in file pdu001.h, from which I quote lines 15-19:
>
> ---
> /* No more need for I2C legacy compatibility for this board.
>   * CONFIG_DM_I2C_COMPAT is defined in ti_armv7_common.h. See the comment
> there
>   * for the right moment to delete the following line.
>   */
> #undef CONFIG_DM_I2C_COMPAT
> ---
>
> Once CONFIG_DM_I2C_COMPAT is removed from ti_armv7_common.h the above
> #undef could be removed as well.
Nevertheless there is a call to i2c_init() in get_dpll_ddr_params() 
(board.c:212).
I'll remove this call in v2 and DM_I2C_COMPAT from config file

>
> regards, Felix