[U-Boot] [PATCH 1/4] sunxi: display: Fix h/vsync TCON polarity bits to indicate active-high

Maxime Ripard maxime.ripard at bootlin.com
Mon Oct 8 08:20:05 UTC 2018


On Sat, Oct 06, 2018 at 12:07:15PM +0200, Paul Kocialkowski wrote:
> Contrary to what is implemented in the Linux kernel, the U-Boot driver
> supporting the sunxi TCON was assuming that the TCON0_IO_POL bits
> indicate active-low signals when set for the hsync and vsync signals.
> 
> After looking at it with a logic analyzer, it appears that the signals
> are active-low with the bits unset and active-high with the bits set.
> 
> Fix this by looking for the right flag (high instead of low) and
> inverting the sync bits in the VIDEO_LCD_MODE declarations.
> 
> Signed-off-by: Paul Kocialkowski <contact at paulk.fr>

For the first three patches,
Acked-by: Maxime Ripard <maxime.ripard at bootlin.com>

It would be good to adjust our wiki as well to not have more of these
inversions creeping in.

Thanks!
Maxime

-- 
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181008/374420ea/attachment.sig>


More information about the U-Boot mailing list