[U-Boot] [PATCH 2/2] pci: Change the first CFG read to Vendor ID in enumeration

Bin Meng bmeng.cn at gmail.com
Tue Oct 9 05:15:49 UTC 2018


Hi Simon,

On Tue, Oct 9, 2018 at 11:41 AM Simon Glass <sjg at chromium.org> wrote:
>
> Hi Bin,
>
> On 8 October 2018 at 02:54, Bin Meng <bmeng.cn at gmail.com> wrote:
> > On Mon, Oct 8, 2018 at 4:36 PM Zhiqiang Hou <Zhiqiang.Hou at nxp.com> wrote:
> >>
> >> From: Hou Zhiqiang <Zhiqiang.Hou at nxp.com>
> >>
> >> As the PCIe specification recommend reading the Vendor ID register
> >> to determine if a Function is present, read the Vendor ID of a
> >> non-existent Function must not result in system error, so we'd better
> >> make the first CFG read to Vendor ID instead of Header Type register
> >> in the PCIe enumeration.
> >>
> >> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou at nxp.com>
> >> ---
> >>  drivers/pci/pci.c | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >
> > Simon, do we need fix the non-DM version or adding new "capability" to
> > the non-DM drivers? I guess the answer is no and we should set some
> > deadline for PCI DM conversion too?
>
> We should not fix or add new features to non-DM PCI. No one should be
> using it at this point.
>
> I agree about the deadline. Do you want to send a patch?
>

Actually I am not sure how to send a patch for such kind of deadline
stuff :-) Please go ahead.

Regards,
Bin


More information about the U-Boot mailing list