[U-Boot] [PATCH v2 21/33] armv8: ls1046ardb: Add TFABOOT support

[Rajesh Bhagat]

> -----Original Message-----
> From: York Sun
> Sent: Monday, October 8, 2018 8:35 PM
> To: Rajesh Bhagat <rajesh.bhagat at nxp.com>; u-boot at lists.denx.de
> Cc: Prabhakar Kushwaha <prabhakar.kushwaha at nxp.com>; Pankit Garg
> <pankit.garg at nxp.com>
> Subject: Re: [PATCH v2 21/33] armv8: ls1046ardb: Add TFABOOT support
> 
> On 10/07/2018 03:22 AM, Rajesh Bhagat wrote:
> > TFABOOT support includes:
> >  - ls1046ardb_tfa_defconfig to be loaded by trusted firmware
> >  - environment address and size changes for TFABOOT
> >  - FMAN address changes for TFABOOT
> >  - define BOOTCOMMAND for TFABOOT
> >
> > Signed-off-by: York Sun <york.sun at nxp.com>
> > Signed-off-by: Pankit Garg <pankit.garg at nxp.com>
> > Signed-off-by: Rajesh Bhagat <rajesh.bhagat at nxp.com>
> > ---
> > Change in v2:
> >  - Merged ls1046ardb TFA boot support patches
> >  - Removed extra CONFIG_TFABOOT flag usage
> >
> >  arch/arm/cpu/armv8/fsl-layerscape/Kconfig |  7 ++++
> >  arch/arm/cpu/armv8/fsl-layerscape/cpu.c   |  9 +++--
> >  board/freescale/ls1046ardb/ddr.c          | 12 ++++++
> >  configs/ls1046ardb_tfa_defconfig          | 49 +++++++++++++++++++++++
> >  include/configs/ls1046a_common.h          | 12 ++++++
> >  include/configs/ls1046ardb.h              | 15 +++++++
> >  6 files changed, 101 insertions(+), 3 deletions(-)  create mode
> > 100644 configs/ls1046ardb_tfa_defconfig
> 

Hi York, 

Thanks for the review. 

> Separate changes to add TFABOOT and put it into a standalone patch.
> Leave the rest in this patch, and squash with patch #22.
> 

Will take care in next version. 

> Do the same squash for every board, i.e. to keep on patch per board.
> This reduces the total number of compiling tests.
> 

Will take care in next version.

> York