[U-Boot] [PATCH] image-fdt: reserve lmb for fdt

[Simon Glass]

On 10 October 2018 at 00:28, Andy Yan <andyshrk at gmail.com> wrote:
> Hi Simon:
>
> Simon Glass <sjg at chromium.org> 于2018年8月30日周四 上午8:42写道：
>>
>> On 7 August 2018 at 05:44, Andy Yan <andy.yan at rock-chips.com> wrote:
>> > Memory region for fdt should be reserved, or they
>> > may be allocated by other module via lmb_alloc.
>> > Then the fdt data will be destroy.
>> >
>> > We found a case on a board with 64MB DRAM like bellow:
>> >
>> > No ethernet found.
>> > Hit any key to stop autoboot:  0
>> > ANDROID: reboot reason: "recovery"
>> > FDT load addr 0x10f00000 size 41 KiB
>> > Booting kernel at 0x2008000 with fdt at 2c8ac00...
>> >
>> > lmb_add base:0x58000 size:0x3fa8000
>> > lmb_add base:0x0 size:0x0
>> > lmb_reserve base:0x34ca2a0 size:0xb35d60
>> >   Booting Android Image at 0x02008000 ...
>> > Kernel load addr 0x02008800 size 3808 KiB
>> > RAM disk load addr 0x11000000 size 9000 KiB
>> > *  fdt: cmdline image address = 0x02c8ac00
>> >   Checking for 'FDT'/'FDT Image' at 02c8ac00
>> > *  fdt: raw FDT blob
>> >    Flattened Device Tree blob at 02c8ac00
>> >    Booting using the fdt blob at 0x2c8ac00
>> >    of_flat_tree at 0x02c8ac00 size 0x00009d6d
>> >    XIP Kernel Image ... OK
>> > do_bootm_states reserve: 0x2008800 -- 0x3b7c30
>> > lmb_reserve base:0x2008800 size:0x3b7c30
>> > no initrd_high
>> > env_get_bootm_size size:66748416(0x3fa8000) tmp:360448(0x58000)
>> > start:360448(0x58000)
>> >    initrd_high = 0x03fa8000, copy_to_ram = 1
>> >    Loading Ramdisk to 02c00000, end 034c9d09 ... OK
>> > ERROR: image is not a fdt - must RESET the board to recover.
>> > FDT creation failed! hanging...### ERROR ### Please RESET the board ###
>> >
>> > Signed-off-by: Andy Yan <andy.yan at rock-chips.com>
>> > ---
>> >
>> >  common/image-fdt.c | 1 +
>> >  1 file changed, 1 insertion(+)
>>
>> Reviewed-by: Simon Glass <sjg at chromium.org>
>
>
> Please don't forget to take it, if it okay.

Tom, this is assigned to you, will you take it?

Regards,
Simon