[U-Boot] [PATCH 01/48] mpc83xx: Introduce ARCH_MPC830*

[Mario Six]

Hi Bin,
On Fri, Sep 28, 2018 at 1:43 PM Bin Meng <bmeng.cn at gmail.com> wrote:
>
> Hi Mario,
>
> On Fri, Sep 28, 2018 at 5:59 PM Mario Six <mario.six at gdsys.cc> wrote:
> >
> > Replace CONFIG_MPC830* with proper CONFIG_ARCH_MPC830* Kconfig options.
> >
> > Signed-off-by: Mario Six <mario.six at gdsys.cc>
> > ---
> >  arch/powerpc/cpu/mpc83xx/Kconfig             | 17 +++++++++++++
> >  arch/powerpc/cpu/mpc83xx/spd_sdram.c         |  2 +-
> >  arch/powerpc/cpu/mpc83xx/speed.c             | 38 ++++++++++++++--------------
> >  arch/powerpc/include/asm/arch-mpc83xx/gpio.h |  2 +-
> >  arch/powerpc/include/asm/fsl_lbc.h           |  2 +-
> >  arch/powerpc/include/asm/global_data.h       |  6 ++---
> >  arch/powerpc/include/asm/immap_83xx.h        | 10 ++++----
> >  arch/powerpc/include/asm/mpc8xxx_spi.h       |  2 +-
> >  board/keymile/km83xx/km83xx.c                |  2 +-
> >  drivers/qe/qe.c                              |  2 +-
> >  drivers/ram/mpc83xx_sdram.c                  |  4 +--
> >  include/configs/MPC8308RDB.h                 |  2 --
> >  include/configs/hrcon.h                      |  2 --
> >  include/configs/km/km8309-common.h           |  2 --
> >  include/configs/km/km83xx-common.h           |  2 +-
> >  include/configs/mpc8308_p1m.h                |  2 --
> >  include/configs/strider.h                    |  2 --
> >  include/linux/immap_qe.h                     |  2 +-
> >  include/mpc83xx.h                            | 24 +++++++++---------
> >  19 files changed, 66 insertions(+), 59 deletions(-)
> >
>
> One generic comments, shouldn't we call these CONFIG_SOC_XXX? Arch
> means architecture, but they are all PowerPC architecture..
>
I copied the CONFIG_ARCH_* convention from mpc85xx, and it seems virtually all
other architectures use CONFIG_ARCH_* as well (aside from davinci, from what I
see, but these are all not even converted to Kconfig, it seems?)

So, I'm not principally against naming the variables CONFIG_SOC_*, but it seems
to not be the current consensus, I think?

> Regards,
> Bin

Best regards,
Mario