[U-Boot] [PATCH 1/1] x86: put global data pointer into the .text section

Bin Meng bmeng.cn at gmail.com
Sat Oct 13 05:38:34 UTC 2018


On Sat, Oct 13, 2018 at 12:57 PM Bin Meng <bmeng.cn at gmail.com> wrote:
>
> Hi Heinrich,
>
> On Sat, Oct 13, 2018 at 9:07 AM Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
> >
> > On x86_64 the field global_data_ptr is assigned before relocation. As
> > global data sections (.data and .bss) overlap with the relocation sections
>
> Good catch! But I think the x86_64 global data is in the .bss, not
> .data. .data is not overlapped with the .rela section.
>
> > (.rela) this destroys the relocation table and leads to spurious errors.
> >
> > By moving the field to the .text section it will not overlap any relocation
> > section anymore.
> >

Looks putting global data to .text will cause the following error:

{standard input}: Assembler messages:
{standard input}:6: Warning: ignoring changed section attributes for .text

I am not sure how to suppress it.

> > Fixes: a160092a610f ("x86: Support global_data on x86_64")
> > Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> > ---

Regards,
Bin


More information about the U-Boot mailing list