[U-Boot] [PATCH 1/1] sandbox: dt: sandbox.dts set skip-localhost = <1>

[Heinrich Schuchardt]

On 10/15/2018 11:52 PM, Joe Hershberger wrote:
> On Sun, Oct 14, 2018 at 2:27 PM Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>>
>> The local interface is not usable for many network operations. It has been
>> disabled in all sandbox device trees except sandbox.dts. Let's disable it
>> here too.
>>
>> 'bootefi selftest' tries to do execute DHCP.  This fails on the lo device.
> 
> Shouldn't the tests be using test.dts?

bootefi selftest is a command inside U-Boot. It does not choose a device
tree.

This is for hand testing, where
> it can be available, and people can use it or not by specifying
> ethact.
> 

make sandbox_defconfig
make
./u-boot -D

uses sandbox.dts.

For all other sandbox*.dts we also set skip-localhost=1. Why should
sandbox_dts be inconsistent with those?

Why would I want to use the cloned local interface?

board/sandbox/README.sandbox does not even mention test.dts. The only
reference is in a Python test, see tools/binman/ftest.py.

The network devices defined in test.dts do not allow to access the real
world. So why should I use it?

Best regards

Heinrich

>>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>> ---
>>  arch/sandbox/dts/sandbox.dts | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/sandbox/dts/sandbox.dts b/arch/sandbox/dts/sandbox.dts
>> index fb866e8807..e0990352fb 100644
>> --- a/arch/sandbox/dts/sandbox.dts
>> +++ b/arch/sandbox/dts/sandbox.dts
>> @@ -49,7 +49,7 @@
>>
>>         ethrawbus {
>>                 compatible = "sandbox,eth-raw-bus";
>> -               skip-localhost = <0>;
>> +               skip-localhost = <1>;
>>         };
>>
>>         eth at 10002000 {
>> --
>> 2.19.1
>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> https://lists.denx.de/listinfo/u-boot