[U-Boot] [PATCH] serial: pl01x: Get clock from clock node if no clock property found

[Michal Simek]

On 16.10.2018 16:57, Alexander Graf wrote:
> 
> 
> On 16.10.18 16:46, Michal Simek wrote:
>> On 16.10.2018 16:25, Alexander Graf wrote:
>>>
>>>
>>> On 03.10.18 07:45, Michal Simek wrote:
>>>> From: Siva Durga Prasad Paladugu <siva.durga.paladugu at xilinx.com>
>>>>
>>>> This patch gets clock from clock nodes if no clock property found
>>>> in serial node.
>>>>
>>>> Signed-off-by: Siva Durga Prasad Paladugu <sivadur at xilinx.com>
>>>> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
>>>
>>> Is this what Linux does? If so, you probably want to explicitly state that.
>>
>> yes. Linux does that.
>> On the other hand reading clock property is something what it is out of
>> dt binding spec.
> 
> In that case, please at least note that in the patch description or
> maybe even in a comment in the code, so the next time someone looks at
> the code they don't get confused :).

Right now I have removed this patch from my PR because it is breaking
generic arm/arm64 model because there are missing some dt patches on
qemu side. Look at our discussing in my PR to Tom done yesterday.

> 
> Speaking of which, why isn't this handled generically already? I was
> expecting that find clocks would be a matter of 2 lines of code - or
> maybe none thanks to magic.

It depends.

M