[U-Boot] [PATCH 1/3] arm64: versal: Add support for new Xilinx Versal ACAPs

[Alexander Graf]

On 16.10.18 16:51, Michal Simek wrote:
> On 16.10.2018 16:23, Alexander Graf wrote:
>>
> 
> ...
> 
>>> +#define ENV_MEM_LAYOUT_SETTINGS \
>>> +	"fdt_high=10000000\0" \
>>> +	"initrd_high=10000000\0" \
>>> +	"fdt_addr_r=0x40000000\0" \
>>> +	"pxefile_addr_r=0x10000000\0" \
>>> +	"kernel_addr_r=0x18000000\0" \
>>> +	"scriptaddr=0x02000000\0" \
>>> +	"ramdisk_addr_r=0x02100000\0"
>>> +
>>> +#define BOOT_TARGET_DEVICES(func) \
>>> +	func(PXE, pxe, na) \
>>> +	func(DHCP, dhcp, na)
>>
>> You seem to support SD as well, shouldn't that be in here too?
> 
> Right now this is align with what devices are wired in qemu.
> Some Kconfig are enabled for SD and QSPI, etc. We will all these devices
> in future for sure.

Ah, ok, I figured since I saw changes to those components that they're
also wired up already. It was hard to tell without the DT :).

> But as you know we are only enabling distro default not any internal
> commands which should be good sign for you.

Yes, this is awesome! :)


Alex