[U-Boot] [PATCH v11 2/6] efi_loader: Drop setup_ok

[Simon Glass]

Hi,

On 15 October 2018 at 11:16, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
> On 10/15/2018 04:17 PM, Simon Glass wrote:
>> This value is stored in data which appears to be read-only with sandbox on
>> my Ubuntu 18.04 machine. In any case it is not good practice to store
>> run-time data in a build-time linker list.
> Yes this should be changed. Otherwise a reset of the board will not put
> us back into the initial status.
>
>>
>> The value does not seem to be that useful, since tests that fail to setup
>> are likely to fail to run also. Let's drop it for now.
>
> With your change we will run execute() even if setup() fails. This
> contradicts the commit message. Please, find a solution that avoids
> calling execute() after a failed setup().

How about we just exit if setup() fails? It should not fail. The test
can fail, but not the setup.

Regards,
Simon