[U-Boot] [PATCH 2/2] pci: Change the first CFG read to Vendor ID in enumeration

[Simon Glass]

On 9 October 2018 at 02:07, Z.q. Hou <zhiqiang.hou at nxp.com> wrote:
> Hi Simon and Bin,
>
> Do I need to send the standalone patch 1/2 in version 2?

I don't think that is needed, no.

- SImon

>
> Thanks,
> Zhiqiang
>
>> -----Original Message-----
>> From: sjg at google.com <sjg at google.com> On Behalf Of Simon Glass
>> Sent: 2018年10月9日 11:41
>> To: Bin Meng <bmeng.cn at gmail.com>
>> Cc: Z.q. Hou <zhiqiang.hou at nxp.com>; U-Boot Mailing List
>> <u-boot at lists.denx.de>; Christian Gmeiner <christian.gmeiner at gmail.com>;
>> Tuomas Tynkkynen <tuomas.tynkkynen at iki.fi>; Bernhard Messerklinger
>> <bernhard.messerklinger at br-automation.com>; Masahiro Yamada
>> <yamada.masahiro at socionext.com>; Mingkai Hu <mingkai.hu at nxp.com>;
>> M.h. Lian <minghuan.lian at nxp.com>
>> Subject: Re: [PATCH 2/2] pci: Change the first CFG read to Vendor ID in
>> enumeration
>>
>> Hi Bin,
>>
>> On 8 October 2018 at 02:54, Bin Meng <bmeng.cn at gmail.com> wrote:
>> > On Mon, Oct 8, 2018 at 4:36 PM Zhiqiang Hou <Zhiqiang.Hou at nxp.com>
>> wrote:
>> >>
>> >> From: Hou Zhiqiang <Zhiqiang.Hou at nxp.com>
>> >>
>> >> As the PCIe specification recommend reading the Vendor ID register to
>> >> determine if a Function is present, read the Vendor ID of a
>> >> non-existent Function must not result in system error, so we'd better
>> >> make the first CFG read to Vendor ID instead of Header Type register
>> >> in the PCIe enumeration.
>> >>
>> >> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou at nxp.com>
>> >> ---
>> >>  drivers/pci/pci.c | 4 ++--
>> >>  1 file changed, 2 insertions(+), 2 deletions(-)
>> >>
>> >
>> > Simon, do we need fix the non-DM version or adding new "capability" to
>> > the non-DM drivers? I guess the answer is no and we should set some
>> > deadline for PCI DM conversion too?
>>
>> We should not fix or add new features to non-DM PCI. No one should be using
>> it at this point.
>>
>> I agree about the deadline. Do you want to send a patch?
>>
>> Regards,
>> Simon