[U-Boot] [PATCH] usb: Do not compile USB_STORAGE with !BLK && !DM_USB

Alexander Graf agraf at suse.de
Fri Oct 19 12:43:35 UTC 2018


The USB storage driver does not compile when CONFIG_BLK is set,
but DM_USB is not set, as we're missing the DM device links for
CONFIG_BLK enabled code paths.

So far it looks like nobody fell into this trap, because no board
enabled CONFIG_BLK and CONFIG_USB_STORAGE while not enabling
CONFIG_DM_USB, but we should still reflect that dependency properly
in Kconfig so that implicit enabling of CONFIG_USB_STORAGE works.

Signed-off-by: Alexander Graf <agraf at suse.de>
---
 drivers/usb/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
index 4fbe172e05..297dda1511 100644
--- a/drivers/usb/Kconfig
+++ b/drivers/usb/Kconfig
@@ -65,6 +65,7 @@ comment "USB peripherals"
 
 config USB_STORAGE
 	bool "USB Mass Storage support"
+	depends on DM_USB || !BLK
 	---help---
 	  Say Y here if you want to connect USB mass storage devices to your
 	  board's USB port.
-- 
2.12.3



More information about the U-Boot mailing list