[U-Boot] [linux-sunxi] [RFC PATCH 0/3] sunxi: extend SPL header to propagate DRAM size

Icenowy Zheng icenowy at aosc.xyz
Mon Oct 22 09:42:18 UTC 2018


在 2018-10-22一的 09:17 +0100,André Przywara写道:
> On 10/22/18 2:26 AM, Icenowy Zheng wrote:
> > 在 2018-05-17四的 09:16 +0100,Andre Przywara写道:
> > > This series tries to solve three issues we currently have on
> > > Allwinner boards:
> > > - The DRAM sizing routine can only cope with power-of-two sized
> > > DRAM.
> > > - The DRAM sizing routine steps through all DRAM, possibly
> > > hitting
> > > secure
> > >   memory.
> > > - The SPL header versioning is quite strict and tends to break
> > > every
> > > time
> > >   we need to update it.
> > > 
> > > So I thought about introducing something along the lines of
> > > semantic
> > > versioning[1], where we can add backwards-compatible changes to
> > > the
> > > SPL
> > > header without breaking every tool. This is introduced in the
> > > first
> > > patch.
> > > The second patch does some refactoring, so that the third patch
> > > can
> > > use
> > > the newly gained freedom to store the DRAM size. The SPL knows
> > > the
> > > DRAM
> > > size very well, so we store this in the SPL header, so that U-
> > > Boot
> > > proper
> > > can pick it up from there. This saves the call to get_ram_size()
> > > with
> > > its deficiencies.
> > > More information in the respective commit messages.
> > > 
> > > I understand that this versioning solution is not fully future-
> > > proof, 
> > > but
> > > we have only one byte for the version, and I just wanted to start
> > > discussion on this.
> > > There is a corresponding patch for sunxi-tools as well I am
> > > posting
> > > shortly.
> > > 
> > > [1] https://semver.org
> > 
> > Could I do some small reworks on this patchset and resend it?
> 
> Yes, please. I was thinking about resending it as well.
> The only issue is that we need the corresponding patch in sunxi-fel
> as
> well, ideally before this one goes in.

I think technically this patchset should be merged BEFORE the sunxi-fel 
patch, because there's no document, and U-Boot works as the document.

> But activity was somewhat low on sunxi-tools last time I mentioned
> this...
> 
> Cheers,
> Andre.
> 
> 
> > We're now facing 3GiB Pine H64 releasing very soon.
> > 
> > > 
> > > Cheers,
> > > Andre.
> > > 
> > > Andre Przywara (3):
> > >   sunxi: Extend SPL header versioning
> > >   sunxi: board.c: refactor SPL header checks
> > >   sunxi: store DRAM size in SPL header
> > > 
> > >  arch/arm/include/asm/arch-sunxi/spl.h | 22 ++++++++----
> > >  board/sunxi/board.c                   | 66
> > > ++++++++++++++++++++++++++++-------
> > >  2 files changed, 70 insertions(+), 18 deletions(-)
> > > 
> > > -- 
> > > 2.14.1
> > > 
> 
> 



More information about the U-Boot mailing list