[U-Boot] [PATCH 12/30] riscv: make use of the barrier functions from Linux

Rick Chen rickchen36 at gmail.com
Tue Oct 23 06:12:08 UTC 2018


> > Hi Lukas,
> >
> > On Sat, Oct 20, 2018 at 6:10 AM Lukas Auer <lukas.auer at aisec.fraunhofer.de>
> > wrote:
> > >
> > > Replace the barrier functions in arch/riscv/include/asm/io.h with
> > > those defined in barrier.h, which is imported from Linux. This version
> > > is modified to remove the include statement of asm-generic/barrier.h,
> > > which is not available in u-boot or required.
> >
> > nits: U-Boot
> >
> > >
> > > Signed-off-by: Lukas Auer <lukas.auer at aisec.fraunhofer.de>
> > > ---
> > > Checkpatch reports style errors in barrier.h. I did not fix them,
> > > because I imported the file from Linux. Is that the correct way to
> > > handle this?
> > >
> >
> > I think this is OK.
> >
> > >  arch/riscv/include/asm/barrier.h | 67 ++++++++++++++++++++++++++++++++
> > >  arch/riscv/include/asm/io.h      | 11 ++----
> > >  2 files changed, 71 insertions(+), 7 deletions(-)  create mode 100644
> > > arch/riscv/include/asm/barrier.h
> > >
> >
> > Reviewed-by: Bin Meng <bmeng.cn at gmail.com>

Reviewed-by: Rick Chen <rick at andestech.com>

> >
> > Regards,
> > Bin


More information about the U-Boot mailing list