[U-Boot] [PATCH 2/5] ARM: rpi_3_32b_defconfig: Add FS_UUID command

Alexander Graf agraf at suse.de
Tue Oct 23 07:33:20 UTC 2018



On 23.10.18 07:38, Otavio Salvador wrote:
> From: Fabio Berton <fabio.berton at ossystems.com.br>

Thanks a lot for the patch :). However, as it is it will be confusing
for people who read the git log to figure out why this patch is in the
tree and what its net effect is.

So could you please provide a proper patch description that explains:

  1) Why do you need the config flag?
  2) Why isn't it set already?
  3) Why are you only touching the 32b defconfig?


Thanks,

Alex

> 
> Signed-off-by: Fabio Berton <fabio.berton at ossystems.com.br>
> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
> ---
> 
>  configs/rpi_3_32b_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configs/rpi_3_32b_defconfig b/configs/rpi_3_32b_defconfig
> index d3d4596ba0..33c476bb4f 100644
> --- a/configs/rpi_3_32b_defconfig
> +++ b/configs/rpi_3_32b_defconfig
> @@ -14,6 +14,7 @@ CONFIG_SYS_PROMPT="U-Boot> "
>  CONFIG_CMD_GPIO=y
>  CONFIG_CMD_MMC=y
>  CONFIG_CMD_USB=y
> +CONFIG_CMD_FS_UUID=y
>  CONFIG_OF_EMBED=y
>  CONFIG_DEFAULT_DEVICE_TREE="bcm2837-rpi-3-b"
>  CONFIG_ENV_FAT_INTERFACE="mmc"
> 


More information about the U-Boot mailing list