[U-Boot] efi: utf8_utf16_strncpy?

AKASHI Takahiro takahiro.akashi at linaro.org
Wed Oct 24 08:39:05 UTC 2018


Hi Heinrich,

Why is the type of the first argument of utf8_utf16_str(n)cpy()
"u16 **", not "u16 *"?
(same issue against utf16_utf8_strncpy())

It's quit confusing, even causing an easy mistake since
it differs from normal strcpy().

What is worse is that we may need additional variable, which is never used,
to avoid unnecessary update of pointer. In all occurrences in current efi
implementation, there is no user of an updated pointer.

Thanks,
-Takahiro Akashi



More information about the U-Boot mailing list