[U-Boot] [PATCH 00/13] dm: DM_FLAG_PRE_RELOC flag clean up

Stephen Warren swarren at wwwdotorg.org
Wed Oct 24 16:26:39 UTC 2018


On 10/24/18 7:36 AM, Bin Meng wrote:
> When a driver declares DM_FLAG_PRE_RELOC flag, it wishes to be
> bound before relocation. However due to a bug in the DM core,
> the flag only takes effect when devices are statically declared
> via U_BOOT_DEVICE(). This bug has been fixed recently by commit
> "dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in
> lists_bind_fdt()", but with the fix, it has a side effect that
> all existing drivers that declared DM_FLAG_PRE_RELOC flag will
> be bound before relocation now. This may expose potential boot
> failure on some boards due to insufficient memory during the
> pre-relocation stage.
> 
> To mitigate this potential impact, the following changes are
> implemented:
> 
> - Remove DM_FLAG_PRE_RELOC flag in the driver, if the driver
>    only supports configuration from device tree (OF_CONTROL)
> - Keep DM_FLAG_PRE_RELOC flag in the driver only if the device
>    is statically declared via U_BOOT_DEVICE()
> - Surround DM_FLAG_PRE_RELOC flag with OF_CONTROL check, for
>    drivers that support both statically declared devices and
>    configuration from device tree
> 
> This series should be applied on top of u-boot-dm/master, for
> v2018.11 release.

Tested-by: Stephen Warren <swarren at nvidia.com>

(I tested this on top of both u-boot/master and u-boot-dm/master just to 
be sure).


More information about the U-Boot mailing list