[U-Boot] [PATCH] imx: mkimage: avoid stop CI when required files not exists

Peng Fan peng.fan at nxp.com
Thu Oct 25 01:14:00 UTC 2018



> -----Original Message-----
> From: Anatolij Gustschin [mailto:agust at denx.de]
> Sent: 2018年10月25日 7:44
> To: Peng Fan <peng.fan at nxp.com>
> Cc: sbabic at denx.de; u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH] imx: mkimage: avoid stop CI when required files
> not exists
> 
> Hi Peng,
> 
> On Wed, 24 Oct 2018 09:49:04 +0000
> Peng Fan peng.fan at nxp.com wrote:
> ...
> > --- /dev/null
> > +++ b/tools/imx8_cntr_image.sh
> > @@ -0,0 +1,32 @@
> > +#!/bin/sh
> > +# SPDX-License-Identifier: GPL-2.0+
> > +#
> > +# script to generate FIT image source for K3 Family boards with #
> > +ATF, OPTEE, SPL and multiple device trees (given on the command line).
> > +# Inspired from board/sunxi/mksunxi_fit_atf.sh
> 
> Please drop this comment, it doesn't describe what the script is actually doing.

Thanks. Fix in V2.

> 
> ...
> > +file=$1
> > +
> > +linecount=`cat ${file} | wc -l`
> > +
> > +for ((i=1; i<=${linecount}; i++));
> > +do
> [ snip ]
> 
> blobs=`awk '/^APPEND/ {print $2} /^IMAGE/ || /^DATA/ {print $3}' $file` for f in
> $blobs; do
> 	if [ ! -f $f ]; then
> 		echo "WARNING '$f' not found, resulting binary is not-functional"
> 	fi;
> done
> 
> will do the checks more efficiently.

Yes. Simpiler.

Thanks,
Peng.

> 
> Thanks,
> 
> Anatolij


More information about the U-Boot mailing list