[U-Boot] [PATCH 06/13] pinctrl: Remove DM_FLAG_PRE_RELOC flag in various drivers

[Simon Glass]

On 24 October 2018 at 07:36, Bin Meng <bmeng.cn at gmail.com> wrote:
> When a driver declares DM_FLAG_PRE_RELOC flag, it wishes to be
> bound before relocation. However due to a bug in the DM core,
> the flag only takes effect when devices are statically declared
> via U_BOOT_DEVICE(). This bug has been fixed recently by commit
> "dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in
> lists_bind_fdt()", but with the fix, it has a side effect that
> all existing drivers that declared DM_FLAG_PRE_RELOC flag will
> be bound before relocation now. This may expose potential boot
> failure on some boards due to insufficient memory during the
> pre-relocation stage.
>
> To mitigate this potential impact, the following changes are
> implemented:
>
> - Remove DM_FLAG_PRE_RELOC flag in the driver, if the driver
>   only supports configuration from device tree (OF_CONTROL)
> - Keep DM_FLAG_PRE_RELOC flag in the driver only if the device
>   is statically declared via U_BOOT_DEVICE()
> - Surround DM_FLAG_PRE_RELOC flag with OF_CONTROL check, for
>   drivers that support both statically declared devices and
>   configuration from device tree
>
> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> ---
>
>  drivers/pinctrl/broadcom/pinctrl-bcm283x.c       | 2 ++
>  drivers/pinctrl/exynos/pinctrl-exynos7420.c      | 1 -
>  drivers/pinctrl/nxp/pinctrl-imx5.c               | 2 ++
>  drivers/pinctrl/nxp/pinctrl-imx6.c               | 2 ++
>  drivers/pinctrl/nxp/pinctrl-imx7.c               | 2 ++
>  drivers/pinctrl/nxp/pinctrl-imx7ulp.c            | 2 ++
>  drivers/pinctrl/pinctrl-single.c                 | 1 -
>  drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.c | 2 ++
>  drivers/pinctrl/uniphier/pinctrl-uniphier-pro5.c | 2 ++
>  9 files changed, 14 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>