[U-Boot] [PATCH 09/13] serial: Remove DM_FLAG_PRE_RELOC flag in various drivers

[Simon Glass]

On 24 October 2018 at 07:36, Bin Meng <bmeng.cn at gmail.com> wrote:
> When a driver declares DM_FLAG_PRE_RELOC flag, it wishes to be
> bound before relocation. However due to a bug in the DM core,
> the flag only takes effect when devices are statically declared
> via U_BOOT_DEVICE(). This bug has been fixed recently by commit
> "dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in
> lists_bind_fdt()", but with the fix, it has a side effect that
> all existing drivers that declared DM_FLAG_PRE_RELOC flag will
> be bound before relocation now. This may expose potential boot
> failure on some boards due to insufficient memory during the
> pre-relocation stage.
>
> To mitigate this potential impact, the following changes are
> implemented:
>
> - Remove DM_FLAG_PRE_RELOC flag in the driver, if the driver
>   only supports configuration from device tree (OF_CONTROL)
> - Keep DM_FLAG_PRE_RELOC flag in the driver only if the device
>   is statically declared via U_BOOT_DEVICE()
> - Surround DM_FLAG_PRE_RELOC flag with OF_CONTROL check, for
>   drivers that support both statically declared devices and
>   configuration from device tree
>
> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> ---
>
>  drivers/serial/altera_jtag_uart.c     | 1 -
>  drivers/serial/altera_uart.c          | 1 -
>  drivers/serial/arm_dcc.c              | 1 -
>  drivers/serial/atmel_usart.c          | 2 ++
>  drivers/serial/ns16550.c              | 2 ++
>  drivers/serial/serial_ar933x.c        | 1 -
>  drivers/serial/serial_arc.c           | 1 -
>  drivers/serial/serial_bcm283x_mu.c    | 2 ++
>  drivers/serial/serial_bcm283x_pl011.c | 2 ++
>  drivers/serial/serial_bcm6345.c       | 1 -
>  drivers/serial/serial_efi.c           | 1 -
>  drivers/serial/serial_intel_mid.c     | 1 -
>  drivers/serial/serial_lpuart.c        | 1 -
>  drivers/serial/serial_meson.c         | 1 -
>  drivers/serial/serial_mvebu_a3700.c   | 1 -
>  drivers/serial/serial_mxc.c           | 2 ++
>  drivers/serial/serial_omap.c          | 2 ++
>  drivers/serial/serial_owl.c           | 1 -
>  drivers/serial/serial_pic32.c         | 1 -
>  drivers/serial/serial_pl01x.c         | 2 ++
>  drivers/serial/serial_s5p.c           | 1 -
>  drivers/serial/serial_sh.c            | 2 ++
>  drivers/serial/serial_sti_asc.c       | 1 -
>  drivers/serial/serial_stm32.c         | 2 ++
>  drivers/serial/serial_xuartlite.c     | 1 -
>  drivers/serial/serial_zynq.c          | 1 -
>  26 files changed, 18 insertions(+), 17 deletions(-)
>

Reviewed-by: Simon Glass <sjg at chromium.org>