[U-Boot] [PATCH v2 01/18] tools: MediaTek: add MTK boot header generation to mkimage

[Simon Glass]

Hi Ryder,

On 12 October 2018 at 01:00, Ryder Lee <ryder.lee at mediatek.com> wrote:
> This patch adds support for MTK boot image generation.
>
> Signed-off-by: Weijie Gao <weijie.gao at mediatek.com>
> Signed-off-by: Ryder Lee <ryder.lee at mediatek.com>
> ---
>  Makefile             |  22 ++
>  common/image.c       |   1 +
>  include/image.h      |   1 +
>  scripts/Makefile.spl |  11 +
>  tools/Makefile       |   1 +
>  tools/mtkimage.c     | 749 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  tools/mtkimage.h     | 199 ++++++++++++++
>  7 files changed, 984 insertions(+)
>  create mode 100644 tools/mtkimage.c
>  create mode 100644 tools/mtkimage.h

The mkimage stuff looks fine.

But can you use binman for the pad/cat part of this? See for example
sunxi. - sunxi-u-boot.dtsi

Also mtkimage.c is too close to mkimage.c - how about mtk_image.c ?

Regards,
Simon