[U-Boot] [PATCH v2 11/18] pinctrl: MediaTek: add pinctrl driver for MT7623 SoC

[Simon Glass]

Hi Ryder,

On 12 October 2018 at 01:01, Ryder Lee <ryder.lee at mediatek.com> wrote:
> This patch adds pinctrl support for MT7623 SoC. And most of the
> structures are used to hold the hardware configuration for each
> pin.
>
> Signed-off-by: Ryder Lee <ryder.lee at mediatek.com>
> Tested-by: Matthias Brugger <matthias.bgg at gmail.com>
> ---
>  drivers/pinctrl/mediatek/Kconfig              |    4 +
>  drivers/pinctrl/mediatek/Makefile             |    1 +
>  drivers/pinctrl/mediatek/pinctrl-mt7623.c     | 1284 +++++++++++++++++++++++++
>  drivers/pinctrl/mediatek/pinctrl-mtk-common.h |    1 +
>  4 files changed, 1290 insertions(+)
>  create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt7623.c

[..]

> +void mtk_rmw(struct udevice *dev, u32 reg, u32 mask, u32 set);

What is this for? It has no comment and is an exported function. We
should not export things from drivers unless there is a good reason.

Regards,
Simon