[U-Boot] [PATCH 2/2] riscv: dts: Add ae350_32.dts for 32 bit

[Bin Meng]

Hi Rick,

On Thu, Oct 25, 2018 at 4:23 PM Rick Chen <rickchen36 at gmail.com> wrote:
>
> Rick Chen <rickchen36 at gmail.com> 於 2018年10月16日 週二 上午10:01寫道：
> >
> > Bin Meng <bmeng.cn at gmail.com> 於 2018年10月8日 週一 下午11:48寫道：
> > >
> > > Hi Rick,
> > >
> > > On Mon, Oct 8, 2018 at 1:37 PM Andes <uboot at andestech.com> wrote:
> > > >
> > > > From: Rick Chen <rick at andestech.com>
> > > >
> > > > Add ae350_32.dts for 32 bit. And also rename
> > > > ae350.dts to ae350_64.dts for 64 bit.
> > > >
> > > > Signed-off-by: Rick Chen <rick at andestech.com>
> > > > Cc: Greentime Hu <greentime at andestech.com>
> > > > ---
> > > >  arch/riscv/dts/ae350.dts    | 229 --------------------------------------------
> > > >  arch/riscv/dts/ae350_32.dts | 229 ++++++++++++++++++++++++++++++++++++++++++++
> > > >  arch/riscv/dts/ae350_64.dts | 229 ++++++++++++++++++++++++++++++++++++++++++++
> > > >  3 files changed, 458 insertions(+), 229 deletions(-)
> > > >  delete mode 100644 arch/riscv/dts/ae350.dts
> > > >  create mode 100644 arch/riscv/dts/ae350_32.dts
> > > >  create mode 100644 arch/riscv/dts/ae350_64.dts
> > > >
> > >
> > > It looks to me that the only difference between these two dts files
> > > are the cpu node (rv32 vs rv64). Can we please put the common part
> > > into a dtsi file and let the main dts file include the dtsi file and
> > > override anything if needed?
> > >
> >
> > Hi Bin
> >
> > I will separate the common into a dtsi file. And others into dts file.
> >
>
> Hi Bin
>
> I am trying to put the common part in a ae350.dtsi from  ae350_32.dts
> and ae350_64.dts.
> But i encounter a problem as below :
>
> smc node for 32 bit :
>
> smc0: smc at e0400000 {
> compatible = "andestech,atfsmc020";
> reg = <0xe0400000 0x1000>;
> };
>
> smc node for 64 bit :
>
> smc0: smc at e0400000 {
> compatible = "andestech,atfsmc020";
> reg = <0x0 0xe0400000 0x0 0x1000>;
> };
>
> Though they look like almost the same, but their reg is different.
> Since can not put in a dtsi file for sharing.
>
> Do you have any idea ?
>

So the register physical address and size are the same and both are
below 4GB. In such case, the 64-bit DTS should have the same
#address-cells and #size-cells as the 32-bit one.

Regards,
Bin