[U-Boot] [PATCH] mtd: nand: lpc32xx mlc: predefine number of NAND chips to support

Miquel Raynal miquel.raynal at bootlin.com
Mon Oct 29 09:29:35 UTC 2018


Hi Vladimir,

Vladimir Zapolskiy <vz at mleia.com> wrote on Fri, 19 Oct 2018 03:21:05
+0300:

> Build option CONFIG_SYS_MAX_NAND_CHIPS is used by NXP LPC32xx NAND MLC
> driver only, as a preparation for potential removal or replacement of
> the option the change predefines CONFIG_SYS_MAX_NAND_CHIPS to 1, same
> value is used by the single user Work Microwave Work 92105 board, thus
> it will be safe now to remove the option as a board specific one.
> 
> Signed-off-by: Vladimir Zapolskiy <vz at mleia.com>
> ---
>  drivers/mtd/nand/raw/lpc32xx_nand_mlc.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/mtd/nand/raw/lpc32xx_nand_mlc.c b/drivers/mtd/nand/raw/lpc32xx_nand_mlc.c
> index 5d4ffea608d9..79d1489dc72c 100644
> --- a/drivers/mtd/nand/raw/lpc32xx_nand_mlc.c
> +++ b/drivers/mtd/nand/raw/lpc32xx_nand_mlc.c
> @@ -82,6 +82,10 @@ struct lpc32xx_nand_mlc_registers {
>  static struct lpc32xx_nand_mlc_registers __iomem *lpc32xx_nand_mlc_registers
>  	= (struct lpc32xx_nand_mlc_registers __iomem *)MLC_NAND_BASE;
>  
> +#if !defined(CONFIG_SYS_MAX_NAND_CHIPS)
> +#define CONFIG_SYS_MAX_NAND_CHIPS	1
> +#endif
> +
>  #define clkdiv(v, w, o) (((1+(clk/v)) & w) << o)
>  
>  /**


If it is safe now, can you also remote the CONFIG_ option now?

Reviewed-by: Miquel Raynal <miquel.raynal at bootlin.com>


Thanks,
Miquèl


More information about the U-Boot mailing list