[U-Boot] [PATCH 5/7] driver: net: ti: introduce common mdio support library

Grygorii Strashko grygorii.strashko at ti.com
Wed Oct 31 17:46:50 UTC 2018



On 10/29/18 2:40 PM, Joe Hershberger wrote:
> On Mon, Oct 29, 2018 at 8:04 AM Hannes Schmelzer <hannes at schmelzer.or.at> wrote:
>>
>>
>> On 10/26/18 5:38 AM, Grygorii Strashko wrote:
>>> All existing TI SoCs network HW have similar MDIO implementation, so
>>> introduce common mdio support library which can be reused by TI networking
>>> drivers.
>>>
>>> Signed-off-by: Grygorii Strashko <grygorii.strashko at ti.com>
>>> ---
>>>    drivers/net/ti/Makefile    |   2 +-
>>>    drivers/net/ti/cpsw_mdio.c | 205 +++++++++++++++++++++++++++++++++++++++++++++
>>>    drivers/net/ti/cpsw_mdio.h |  18 ++++
>>>    3 files changed, 224 insertions(+), 1 deletion(-)
>>>    create mode 100644 drivers/net/ti/cpsw_mdio.c
>>>    create mode 100644 drivers/net/ti/cpsw_mdio.h
>>>
>> Hi,
>> why we don't combine this with:
>> http://patchwork.ozlabs.org/patch/939726/ ? looks much more elegant to me.
> 
> I agree we should be moving that direction, but consolidating TI MDIO
> implementation is fairly orthogonal. Also haven't heard back from Ken
> on feedback to that patch.

The mdio here is not modeled as device/driver and I, honestly, see no reasons for this
at least now.

-- 
regards,
-grygorii


More information about the U-Boot mailing list