[U-Boot] [PATCH 1/5] fix: env: Fix the SPI flash device setup for DM mode
Stefan Roese
sr at denx.de
Wed Sep 19 13:11:43 UTC 2018
On 29.08.2018 15:34, kostap at marvell.com wrote:
> From: Konstantin Porotchkin <kostap at marvell.com>
>
> For some reason the spi_flash_probe_bus_cs() is called
> inside the setup_flash_device() with zero values in place
> of configurated SPI flash mode and maximum flash speed.
> This code causes HALT error during startup environment
> relocation on some platforms - namely Armada-38x-GP board.
> Fix the function call by replacing zeros with the appropriate
> values - CONFIG_ENV_SPI_MAX_HZ and CONFIG_ENV_SPI_MODE.
>
> Signed-off-by: Konstantin Porotchkin <kostap at marvell.com>
> Cc: Igal Liberman <igall at marvell.com>
> Cc: Stefan Roese <sr at denx.de>
> ---
> env/sf.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/env/sf.c b/env/sf.c
> index 4945105..2e3c600 100644
> --- a/env/sf.c
> +++ b/env/sf.c
> @@ -58,7 +58,8 @@ static int setup_flash_device(void)
>
> /* speed and mode will be read from DT */
> ret = spi_flash_probe_bus_cs(CONFIG_ENV_SPI_BUS, CONFIG_ENV_SPI_CS,
> - 0, 0, &new);
> + CONFIG_ENV_SPI_MAX_HZ, CONFIG_ENV_SPI_MODE,
> + &new);
> if (ret) {
> set_default_env("spi_flash_probe_bus_cs() failed", 0);
> return ret;
>
Applied to u-boot-marvell/master
Thanks,
Stefan
More information about the U-Boot
mailing list