[U-Boot] [PATCH] uclass: Use uclass_foreach_dev() macro instead of open coding

Simon Glass sjg at chromium.org
Wed Sep 19 15:30:37 UTC 2018


Hi,

On 18 September 2018 at 02:08, Liviu Dudau <Liviu.Dudau at foss.arm.com> wrote:
>
> On Tue, Sep 18, 2018 at 04:06:13AM +0200, Simon Glass wrote:
> > On 17 September 2018 at 10:44, Liviu Dudau <Liviu.Dudau at foss.arm.com> wrote:
> > > Use the uclass_foreach_dev() macro instead of the open coded version.
> > >
> > > Signed-off-by: Liviu Dudau <liviu.dudau at foss.arm.com>
> > > ---
> > >  drivers/core/uclass.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Reviewed-by: Simon Glass <sjg at chromium.org>
> >
> > Perhaps you could also convert a few usages?
>
> Not sure what you mean. Are you suggesting that I should convert more of
> the code that uses the open coded version into uclass_foreach_dev() ?

Yes. After all, at present your macro is just dead code :-)

Regards,
Simon


More information about the U-Boot mailing list