[U-Boot] [PATCH] uclass: Use uclass_foreach_dev() macro instead of open coding

[Liviu Dudau]

On Wed, Sep 19, 2018 at 09:30:37AM -0600, Simon Glass wrote:
> Hi,
> 
> On 18 September 2018 at 02:08, Liviu Dudau <Liviu.Dudau at foss.arm.com> wrote:
> >
> > On Tue, Sep 18, 2018 at 04:06:13AM +0200, Simon Glass wrote:
> > > On 17 September 2018 at 10:44, Liviu Dudau <Liviu.Dudau at foss.arm.com> wrote:
> > > > Use the uclass_foreach_dev() macro instead of the open coded version.
> > > >
> > > > Signed-off-by: Liviu Dudau <liviu.dudau at foss.arm.com>
> > > > ---
> > > >  drivers/core/uclass.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > Reviewed-by: Simon Glass <sjg at chromium.org>
> > >
> > > Perhaps you could also convert a few usages?
> >
> > Not sure what you mean. Are you suggesting that I should convert more of
> > the code that uses the open coded version into uclass_foreach_dev() ?
> 
> Yes. After all, at present your macro is just dead code :-)

I think there is some confusion here. I didn't write the macro, it is
present in include/dm/uclass.h since you have introduced it in commit 6494d708bfc630ac0
("dm: Add base driver model support"). All I have done was to notice
that in uclass.c the list_for_each_entry() line can be replaced by the
macro with the same effect.

I also didn't get what you meant by "your macro is just dead code".

Best regards,
Liviu

> 
> Regards,
> Simon

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯