[U-Boot] [PATCH v2 0/7] [RESEND] Improvements for the dwc3_generic driver

Lukasz Majewski lukma at denx.de
Fri Sep 21 09:24:12 UTC 2018


Hi Jean-Jacques,

> On 21/09/2018 10:50, Lukasz Majewski wrote:
> > Hi Jean-Jacques,
> >  
> >> Hi Marek,
> >>
> >> I haven't heard of you on this series.
> >>
> >> It is already a resend and has been tested on 2 platforms (zcu100
> >> and dra7/am57).
> >>
> >> Can you please consider it for inclusion?  
> > This is not Marek to blame for the delay - I had some non open
> > source tasks to finish (and I do apologise for this situation).  
> Thanks. I am not blaming anyone.

:-)

Could you check the build result?
https://travis-ci.org/lmajewski/u-boot-dfu/builds/431388980

I do see some issues with "Freescale ARM32/ARM64".

> I just wanted to make sure that this 
> wasn't lost in limbo.
> 
> >
> > Your patches are now under build testing on travis-CI:
> > https://travis-ci.org/lmajewski/u-boot-dfu/builds/431388980
> >
> > I will send the PR after CI finish.
> >  
> >> Thanks,
> >>
> >> JJ
> >>
> >>
> >>
> >> On 04/09/2018 15:42, Jean-Jacques Hiblot wrote:  
> >>> Resending this series after rebasing on top of latest u-boot.
> >>>
> >>> This series aims at bringing improvements to the dwc3_generic
> >>> driver so that it can be used by most of the platforms using the
> >>> dwc3 controller.
> >>>
> >>> I tested this on with DRA7 and AM57x platforms for both Peripheral
> >>> and Host operations. The code to enable DM USB host & dev support
> >>> for those platforms will be submitted in a separate series.
> >>>
> >>> Michal Simek has tested this series:
> >>> " I have tested it on zcu100 with usb stick, usb to ethernet
> >>> converter and also dfu.
> >>> Tested-by: Michal Simek <michal.simek at xilinx.com>"
> >>>
> >>> Enhancements:
> >>> - use separate Kconfig option for DM USB Periphal and DM USB Host.
> >>> This allow platforms to keep their non-DM USB peripheral code and
> >>> use the DM USB host.
> >>> - fixes the bind/probe confusion in dwc3_generic. The probe is
> >>> done when the USB device is first needed.
> >>> - handles PHYs when in the peripheral mode. The code to handle the
> >>> PHYs is shared with the host side
> >>> - handles clock and reset
> >>> - bind host controller to the more generic driver 'xhci-dwc3'
> >>>
> >>>
> >>> Changes in v2:
> >>> - Updated commit log
> >>> - Fixed typo in thordown.c
> >>> - select DM_USB_DEV by default for zynqmp platforms
> >>>
> >>> Jean-Jacques Hiblot (7):
> >>>     usb: gadget: Do not call board_usb_xxx() directly in USB
> >>> gadget drivers
> >>>     usb: introduce a separate config option for DM USB device
> >>>     usb: udc: implement DM versions of
> >>>       usb_gadget_initialize()/_release()/_handle_interrupt()
> >>>     dwc3_generic: do not probe the USB device driver when it's
> >>> bound dwc3: move phy operation to core.c
> >>>     dwc3-generic: Handle the PHYs, the clocks and the reset lines
> >>>     dwc3-generic: Add select_dr_mode operation
> >>>
> >>>    arch/arm/Kconfig                  |   2 +
> >>>    cmd/fastboot.c                    |   4 +-
> >>>    cmd/rockusb.c                     |   4 +-
> >>>    cmd/thordown.c                    |   4 +-
> >>>    cmd/usb_gadget_sdp.c              |   4 +-
> >>>    cmd/usb_mass_storage.c            |   4 +-
> >>>    common/dfu.c                      |   6 +-
> >>>    drivers/usb/Kconfig               |   6 ++
> >>>    drivers/usb/dwc3/Kconfig          |   7 +-
> >>>    drivers/usb/dwc3/core.c           |  86 +++++++++++++++-
> >>>    drivers/usb/dwc3/dwc3-generic.c   | 207
> >>> +++++++++++++++++++++++++++++---------
> >>> drivers/usb/dwc3/ep0.c            |   1 -
> >>> drivers/usb/gadget/ether.c        |  38 +------
> >>> drivers/usb/gadget/udc/udc-core.c |  44 +++++++-
> >>> drivers/usb/host/xhci-dwc3.c      |  93 ++---------------
> >>> include/dwc3-uboot.h              |   7 ++
> >>> include/linux/usb/gadget.h        |  18 ++++ 17 files changed, 351
> >>> insertions(+), 184 deletions(-)  
> >
> >
> >
> > Best regards,
> >
> > Lukasz Majewski
> >
> > --
> >
> > DENX Software Engineering GmbH,      Managing Director: Wolfgang
> > Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,
> > Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email:
> > wd at denx.de  
> 




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180921/585553c3/attachment.sig>


More information about the U-Boot mailing list