[U-Boot] [PATCH v1 05/14] colibri-imx6ull: fix ethernet phy power on

[Igor Opaniuk]

Hi Marcel,

On Fri, Mar 29, 2019 at 1:38 PM Marcel Ziswiler <marcel at ziswiler.com> wrote:
>
> From: Marcel Ziswiler <marcel.ziswiler at toradex.com>
>
> Just give the new Ethernet PHY power save mode circuitry time to settle.
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler at toradex.com>
> Acked-by: Max Krummenacher <max.krummenacher at toradex.com>
>
> ---
>
>  board/toradex/colibri-imx6ull/colibri-imx6ull.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/board/toradex/colibri-imx6ull/colibri-imx6ull.c b/board/toradex/colibri-imx6ull/colibri-imx6ull.c
> index fe60b8e870..b6f45edb86 100644
> --- a/board/toradex/colibri-imx6ull/colibri-imx6ull.c
> +++ b/board/toradex/colibri-imx6ull/colibri-imx6ull.c
> @@ -263,6 +263,9 @@ static int setup_fec(void)
>                         IOMUX_GPR1_FEC2_CLOCK_MUX2_SEL_MASK,
>                         IOMUX_GPR1_FEC2_CLOCK_MUX1_SEL_MASK);
>
> +       /* give new Ethernet PHY power save mode circuitry time to settle */
> +       mdelay(300);

Just curious, is this some empirical value for the delay needed or
it's documented somethere?
The first question from my side was why particularly 300?

> +
>         return 0;
>  }
>
> --
> 2.20.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot



-- 
Best regards - Freundliche Grüsse - Meilleures salutations

Igor Opaniuk

mailto: igor.opaniuk at gmail.com
skype: igor.opanyuk
+380 (93) 836 40 67
http://ua.linkedin.com/in/iopaniuk