[U-Boot] [PATCH v1 05/14] colibri-imx6ull: fix ethernet phy power on

[Marcel Ziswiler]

On Wed, 2019-04-03 at 10:12 +0200, Igor Opaniuk wrote:
> Hi Marcel,
> 
> On Fri, Mar 29, 2019 at 1:38 PM Marcel Ziswiler <marcel at ziswiler.com>
> wrote:
> > From: Marcel Ziswiler <marcel.ziswiler at toradex.com>
> > 
> > Just give the new Ethernet PHY power save mode circuitry time to
> > settle.
> > 
> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler at toradex.com>
> > Acked-by: Max Krummenacher <max.krummenacher at toradex.com>
> > 
> > ---
> > 
> >  board/toradex/colibri-imx6ull/colibri-imx6ull.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/board/toradex/colibri-imx6ull/colibri-imx6ull.c
> > b/board/toradex/colibri-imx6ull/colibri-imx6ull.c
> > index fe60b8e870..b6f45edb86 100644
> > --- a/board/toradex/colibri-imx6ull/colibri-imx6ull.c
> > +++ b/board/toradex/colibri-imx6ull/colibri-imx6ull.c
> > @@ -263,6 +263,9 @@ static int setup_fec(void)
> >                         IOMUX_GPR1_FEC2_CLOCK_MUX2_SEL_MASK,
> >                         IOMUX_GPR1_FEC2_CLOCK_MUX1_SEL_MASK);
> > 
> > +       /* give new Ethernet PHY power save mode circuitry time to
> > settle */
> > +       mdelay(300);
> 
> Just curious, is this some empirical value for the delay needed or
> it's documented somethere?
> The first question from my side was why particularly 300?

The hardware guys just looked at it with the oscilloscope and discussed
that 300 msec would be a safe value to use (;-p).

> > +
> >         return 0;
> >  }
> > 
> > --
> > 2.20.1
> > 
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot at lists.denx.de
> > https://lists.denx.de/listinfo/u-boot