[U-Boot] [PATCH 28/40] x86: Add a sysreset driver for the Intel PCH

[Bin Meng]

Hi Simon,

On Wed, Apr 3, 2019 at 10:22 AM Simon Glass <sjg at chromium.org> wrote:
>
> Hi Bin,
>
> On Fri, 22 Feb 2019 at 00:20, Bin Meng <bmeng.cn at gmail.com> wrote:
> >
> > Hi Simon,
> >
> > On Wed, Jan 30, 2019 at 12:00 PM Simon Glass <sjg at chromium.org> wrote:
> > >
> > > Intel SoCs support a fairly stardard reset mechanism which can support
> > > powering off the device. Add support for this and enable it by default on
> > > broadwell, which already has the necessary pm.h header file.
> > >
> > > This driver augments the standard x86 sysreset driver.
> > >
> >
> > I think we need update the existing sysreset_x86 driver to support
> > SYSRESET_POWER_OFF, instead of creating a new driver to do such.
> >
> > We can add a new PCH ioctl code to get the pmbase, and do the ACPI
> > power off in the sysreset_x86 driver.
>
> So are you saying that the registers are the same for all x86 chips?
> From what I can tell, the offsets vary.

Yes, the offsets might be different, so instead of getting only the
pmbase, we need do something like getting ACPI PM register block
information from the PCH driver. That's how acpi_create_fadt() passes
ACPI register block information to the OS.

Regards,
Bin