[U-Boot] arm: sunxi: Bananapi_M2_Ultra not working with DM_MMC

[Paul Kocialkowski]

Hi,

Le lundi 08 avril 2019 à 09:25 -0400, Tom Rini a écrit :
> On Mon, Apr 08, 2019 at 06:51:48PM +0530, Jagan Teki wrote:
> > + Andre
> > 
> > On Mon, Apr 8, 2019 at 6:40 PM Tom Rini <trini at konsulko.com> wrote:
> > > On Mon, Apr 08, 2019 at 06:23:29PM +0530, Jagan Teki wrote:
> > > > Hi Paul,
> > > > 
> > > > On Mon, Apr 8, 2019 at 6:00 PM Paul Kocialkowski
> > > > <paul.kocialkowski at bootlin.com> wrote:
> > > > > Hi,
> > > > > 
> > > > > On Thu, 2019-04-04 at 05:51 -0300, Pablo Sebastián Greco wrote:
> > > > > > A few days ago I tried to boot my Bananapi_M2_Ultra with 2019.04rc, I
> > > > > > found that it wasn't booting, 2019.01 was working ok.
> > > > > > Bisecting indicated that the problem was after
> > > > > > http://git.denx.de/?p=u-boot.git;a=commitdiff;h=a7cca5793774ee139b75a704d6efaa4d29f09f93
> > > > > 
> > > > > I think the patch should be reverted ASAP since it obviously breaks
> > > > > some supported configs. Sadly, the offending commit doesn't say
> > > > > anything about the test coverage for the change and what the status is
> > > > > after it. There is probably a reason why it was enabled for sun4i only
> > > > > before and there must have been a motivation for doing this on all
> > > > > sunxi platforms, but then again, the commit message says nothing about
> > > > > those underlying reasons.
> > > > > 
> > > > > I believe we should be more strict on patch review and not let any
> > > > > change bringing such a major change get applied with a commit message
> > > > > that provides no context about why the change is okay and how it was
> > > > > tested.
> > > > 
> > > > Appropriate your concern.
> > > > 
> > > > If you please list what all boards are not working with this effect,
> > > > please write back. we will defiantly look into it. All these changes
> > > > were merged in MW which is 2.5 months back, commenting in final stage
> > > > like this is not the professional way.
> > > 
> > > OK, but what platforms was this all tested on?  Thanks!
> > 
> > We have tested DM_MMC all the Allwinner SoC platforms and I couldn't
> > find any mmc issues so-far on my boards atleast.
> 
> Sorry, let me try and be clearer.  Which hardware platforms did you test
> this on?  There's quite a lot of Allwinner SoCs, and it's not clear at
> all if Paul's problem is because of something on the SoC on the Bananapi
> M2 Ultra (because it's not clear if another platform with that same SoC
> was tested) or how the board is wired (DM MMC is fine on that SoC, but
> was tested on something where uSD/MMC are opposite of that platform or
> ...).

For the record, it's not my setup that was broken but Pablo Sebastián
Greco's. I suggested that we revert the offending patch for now and
replace it with a proper one that provides some context about the
change.

Cheers,

Paul

-- 
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com