[U-Boot] [PATCH] ARM: rmobile: ulcb/salvator-x: re-enable rcar-common/common.c

[Eugeniu Rosca]

On Tue, Apr 09, 2019 at 05:23:17PM +0200, Marek Vasut wrote:
> On 4/9/19 5:08 PM, Eugeniu Rosca wrote:
[..]
> > diff --git a/board/renesas/rcar-common/common.c b/board/renesas/rcar-common/common.c

[..]

> This should be a separate patch, one which only removes this code which
> is unused. Presumably the whole file should just be removed.

[..]

> > diff --git a/board/renesas/ulcb/Makefile b/board/renesas/ulcb/Makefile
> >  
> > -obj-y	:= ulcb.o cpld.o
> > +obj-y	:= ulcb.o cpld.o ../rcar-common/common.o
> 
> This ends up including an empty file, which is useless.

Do you plan to push a v2 for
https://patchwork.ozlabs.org/patch/1051603/ ?

If so, board/renesas/rcar-common/common.c might be the perfect
place to host the duplicated code, i.e. you will need to re-add
board/renesas/rcar-common/common.c to the build chain.

> 
> -- 
> Best regards,
> Marek Vasut

Best regards,
Eugeniu.