[U-Boot] [PATCH] ARM: rmobile: ulcb/salvator-x: re-enable rcar-common/common.c

[Marek Vasut]

On 4/9/19 5:34 PM, Eugeniu Rosca wrote:
> On Tue, Apr 09, 2019 at 05:23:17PM +0200, Marek Vasut wrote:
>> On 4/9/19 5:08 PM, Eugeniu Rosca wrote:
> [..]
>>> diff --git a/board/renesas/rcar-common/common.c b/board/renesas/rcar-common/common.c
> 
> [..]
> 
>> This should be a separate patch, one which only removes this code which
>> is unused. Presumably the whole file should just be removed.
> 
> [..]
> 
>>> diff --git a/board/renesas/ulcb/Makefile b/board/renesas/ulcb/Makefile
>>>  
>>> -obj-y	:= ulcb.o cpld.o
>>> +obj-y	:= ulcb.o cpld.o ../rcar-common/common.o
>>
>> This ends up including an empty file, which is useless.
> 
> Do you plan to push a v2 for
> https://patchwork.ozlabs.org/patch/1051603/ ?

I was rather thinking of doing a follow-up patch, so that in case
something broke, I could bisect it. And maybe this is actually better,
since I could apply the patches in this order:
- The DRAM DT config
- The common.c cleanup of this patch
- Perform the deduplication as needed and enable common.c in the build

So can you split the common.c cleanup from this patch so I can use it?

> If so, board/renesas/rcar-common/common.c might be the perfect
> place to host the duplicated code, i.e. you will need to re-add
> board/renesas/rcar-common/common.c to the build chain.
> 
>>
>> -- 
>> Best regards,
>> Marek Vasut
> 
> Best regards,
> Eugeniu.
> 


-- 
Best regards,
Marek Vasut