[U-Boot] [PATCH] i2c: mxc: Hide kconfig based control in DM_I2C mode

[Heiko Schocher]

Hello Trent,

Am 12.04.2019 um 21:19 schrieb Trent Piepho:
> These options only apply when not using DM_I2C.  When using device
> trees, the dt will enable and control the speeds of the I2C
> controller(s) and these configuration options have no effect.
> 
> So disable them in DM_I2C mode.  Otherwise they show up as decoys, and
> make it look like one is enabling I2C controllers and setting the speed
> when really it's doing nothing.
> 
> Cc: Sriram Dash <sriram.dash at nxp.com>
> Cc: Priyanka Jain <priyanka.jain at nxp.com>
> Cc: Heiko Schocher <hs at denx.de>
> Signed-off-by: Trent Piepho <tpiepho at impinj.com>
> ---
>   drivers/i2c/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Your patch has checkpatch warning:


ERROR: DOS line endings
#142: FILE: drivers/i2c/Kconfig:164:
+if SYS_I2C_MXC && !DM_I2C^M$

Fixed this locally, please check furhter patches.

> diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
> index 1ef22e6bcd..df7fc7db0a 100644
> --- a/drivers/i2c/Kconfig
> +++ b/drivers/i2c/Kconfig
> @@ -161,7 +161,7 @@ config SYS_I2C_MXC
>   	  channels and operating on standard mode upto 100 kbits/s and fast
>   	  mode upto 400 kbits/s.
>   
> -if SYS_I2C_MXC
> +if SYS_I2C_MXC && !DM_I2C
>   config SYS_I2C_MXC_I2C1
>   	bool "NXP MXC I2C1"
>   	help

Reviewed-by: Heiko Schocher <hs at denx.de>

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de