[U-Boot] [PATCH] i2c: mxc: Hide kconfig based control in DM_I2C mode

[Heiko Schocher]

Hello Trent,

Am 30.04.2019 um 06:24 schrieb Heiko Schocher:
> Hello Trent,
> 
> Am 12.04.2019 um 21:19 schrieb Trent Piepho:
>> These options only apply when not using DM_I2C.  When using device
>> trees, the dt will enable and control the speeds of the I2C
>> controller(s) and these configuration options have no effect.
>>
>> So disable them in DM_I2C mode.  Otherwise they show up as decoys, and
>> make it look like one is enabling I2C controllers and setting the speed
>> when really it's doing nothing.
>>
>> Cc: Sriram Dash <sriram.dash at nxp.com>
>> Cc: Priyanka Jain <priyanka.jain at nxp.com>
>> Cc: Heiko Schocher <hs at denx.de>
>> Signed-off-by: Trent Piepho <tpiepho at impinj.com>
>> ---
>>   drivers/i2c/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Your patch has checkpatch warning:
> 
> 
> ERROR: DOS line endings
> #142: FILE: drivers/i2c/Kconfig:164:
> +if SYS_I2C_MXC && !DM_I2C^M$
> 
> Fixed this locally, please check furhter patches.

Also, your patch breaks travis build, see:

https://travis-ci.org/hsdenx/u-boot-i2c/jobs/526286390

        arm:  +   wandboard
+board/wandboard/wandboard.c: In function 'board_init':
+board/wandboard/wandboard.c:466:15: error: 'CONFIG_SYS_MXC_I2C1_SPEED' undeclared (first use in 
this function); did you mean 'CONFIG_SYS_MMC_ENV_DEV'?
+  setup_i2c(1, CONFIG_SYS_MXC_I2C1_SPEED, 0x7f, &mx6dl_i2c2_pad_info);
+               ^~~~~~~~~~~~~~~~~~~~~~~~~
+               CONFIG_SYS_MMC_ENV_DEV
+board/wandboard/wandboard.c:466:15: note: each undeclared identifier is reported only once for each 
function it appears in
+board/wandboard/wandboard.c:469:16: error: 'CONFIG_SYS_MXC_I2C2_SPEED' undeclared (first use in 
this function); did you mean 'CONFIG_SYS_MXC_I2C1_SPEED'?
+   setup_i2c(2, CONFIG_SYS_MXC_I2C2_SPEED, 0x7f, &mx6q_i2c3_pad_info);
+                ^~~~~~~~~~~~~~~~~~~~~~~~~
+                CONFIG_SYS_MXC_I2C1_SPEED
+make[2]: *** [board/wandboard/wandboard.o] Error 1
+make[1]: *** [board/wandboard] Error 2
+make: *** [sub-make] Error 2

Please check.

bye,
Heiko
> 
>> diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
>> index 1ef22e6bcd..df7fc7db0a 100644
>> --- a/drivers/i2c/Kconfig
>> +++ b/drivers/i2c/Kconfig
>> @@ -161,7 +161,7 @@ config SYS_I2C_MXC
>>         channels and operating on standard mode upto 100 kbits/s and fast
>>         mode upto 400 kbits/s.
>> -if SYS_I2C_MXC
>> +if SYS_I2C_MXC && !DM_I2C
>>   config SYS_I2C_MXC_I2C1
>>       bool "NXP MXC I2C1"
>>       help
> 
> Reviewed-by: Heiko Schocher <hs at denx.de>
> 
> bye,
> Heiko

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de