[U-Boot] [PATCH V3 1/4] clk: imx: add Kconfig entry for i.MX8MM

[Lukasz Majewski]

On Tue, 13 Aug 2019 09:07:03 +0000
Peng Fan <peng.fan at nxp.com> wrote:

> Hi Lukasz,
> 
> > Subject: Re: [PATCH V3 1/4] clk: imx: add Kconfig entry for i.MX8MM
> > 
> > Hi Peng,
> > 
> > On Fri, Aug 9, 2019 at 5:02 AM Peng Fan <peng.fan at nxp.com> wrote:  
> > >
> > > Add Kconfig entry for i.MX8MM
> > >
> > > Signed-off-by: Peng Fan <peng.fan at nxp.com>
> > > ---
> > >  drivers/clk/Kconfig     |  4 ++--
> > >  drivers/clk/imx/Kconfig | 16 ++++++++++++++++
> > >  2 files changed, 18 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index
> > > a3f0171b45..fce595b4b3 100644
> > > --- a/drivers/clk/Kconfig
> > > +++ b/drivers/clk/Kconfig
> > > @@ -48,7 +48,7 @@ config CLK_BOSTON
> > >
> > >  config SPL_CLK_CCF
> > >         bool "SPL Common Clock Framework [CCF] support "
> > > -       depends on SPL_CLK_IMX6Q
> > > +       depends on SPL_CLK_IMX6Q || ARCH_IMX8M  
> > 
> > I am wondering why this depends on i.MX. Shouldn't it be SoC
> > agnostic?  
> 
> Are you ok to expose the Kconfig for all with remove the depends on?
> 

If it doesn't harm other SoCs I'm fine with it (but please check it
first).

I will review those patches tonight, or tomorrow morning.

> Thanks
> Peng
> 
> >   
> > >         help
> > >           Enable this option if you want to (re-)use the Linux
> > > kernel's  
> > Common  
> > >           Clock Framework [CCF] code in U-Boot's SPL.
> > > @@ -62,7 +62,7 @@ config SPL_CLK_COMPOSITE_CCF
> > >
> > >  config CLK_CCF
> > >         bool "Common Clock Framework [CCF] support "
> > > -       depends on CLK_IMX6Q || SANDBOX_CLK_CCF
> > > +       depends on CLK_IMX6Q || ARCH_IMX8M || SANDBOX_CLK_CCF  
> > 
> > Same here.
> > 
> > It doesn't look like a good idea to keep expanding this Kconfig
> > every time a new SoC wants to use the CCF.  



Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190813/18d9ae75/attachment.sig>